Servers tidying up #773
Merged
Servers tidying up #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop interactive prompt for server name * Extract out `registerServer()` to reduce duplicated code * Move tests from `test-cert.R` to `test-servers.R` * Add more tests
aronatkins
approved these changes
Mar 16, 2023
| gcFirst = FALSE | ||
| ) | ||
|
|
||
| start <- proc.time() |
There was a problem hiding this comment.
It is more interesting to obtain the elapsed time than the process time, since an HTTP request could take a long time, but consume no CPU.
There was a problem hiding this comment.
Confusingly proc.time() returns user, system, and elapsed time:
> proc.time()
user system elapsed
766.150 229.515 246336.283 #Conflicts: # R/http-libcurl.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerServer()to reduce duplicated codetest-cert.Rtotest-servers.R