New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ENV var to disable launcher #9

Closed

colearendt opened this issue Dec 19, 2019 · 1 comment · Fixed by #31

Contributor

colearendt commented Dec 19, 2019 •

edited

Loading

rstudio-docker-products/server-pro/startup.sh

Lines 37 to 38 in a7ddff5

    
           /usr/lib/rstudio-server/bin/rstudio-launcher > /dev/null 2>&1 & 
        
           wait-for-it.sh localhost:5559 -t 0

I think to make this container ideal, we should make launcher "optional." A few reasons for this:

If you want to use legacy behavior without the launcher (i.e. project sharing, load balancing local sessions, etc.)
If you want to run the launcher in a separate container from RSP. This pattern isn't common yet, but it is something we may want to think about as an option longer term 😄

Contributor

danielfrg commented Dec 19, 2019

Agree, I thought about but decided to leave that out for the first pass.

colearendt mentioned this issue

Explore an init / entrypoint directory #24

Open

colearendt mentioned this issue

Floating licensing and launcher off option #31

Merged

colearendt closed this as completed in #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment