Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite any user own existing replication R script for rjournal_article #433

Closed
cderv opened this issue Aug 16, 2021 · 2 comments · Fixed by #439
Closed

Do not overwrite any user own existing replication R script for rjournal_article #433

cderv opened this issue Aug 16, 2021 · 2 comments · Fixed by #439
Assignees
Labels
bug an unexpected problem or unintended behavior next to consider for next release

Comments

@cderv
Copy link
Collaborator

cderv commented Aug 16, 2021

This was originally posted in #394 (comment)

We need to watch out to not override any existing R file that would be owned by the user and not generated by us.

Two ideas:

  • Provide an opt-out mechanism for the purl-ing.
    Something like

    output: 
      rjournal_article: 
        purl: false
  • Use a special comment header # Do not edit as done in other tools so that we know that this is our file and we can overwrite.

@cderv cderv added bug an unexpected problem or unintended behavior next to consider for next release labels Aug 16, 2021
@cderv cderv self-assigned this Aug 16, 2021
@cderv
Copy link
Collaborator Author

cderv commented Sep 9, 2021

@Enchufa2 I have made a PR with the second solution. If you want to try and give your thoughts you are more than welcome. Thank you!

@cderv cderv closed this as completed in #439 Sep 9, 2021
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior next to consider for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant