-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R file produced by rjournal_article
is not replaced by new one
#394
Comments
I suppose this is a feature to automatically generate the replication script from the Rmd. But I always maintain a separate |
I see no way to switch this off. And given that previously it was possible to maintain a custom replication script, I consider this a regression. A proper fix would be to add some comment to the generated file (like "this was automatically generated, do not edit by hand"), and only overwrite it if such comment is present. In this way, previous behavior would be preserved, as well as the originally intended feature. |
Hi @Enchufa2 ! Thanks for the report. This is indeed something we did not think through. The feature is to automatically generate the R script from the content of the Rmd file (using We could also provide an argument in the function to opt-out this: output:
rjournal_article:
purl: false I like your suggestion though with the special comment in the script. I'll open an issue to track your report specifically. |
Nice, thanks! |
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary. |
We forgot to set
overwrite = FALSE
here I think:rticles/R/rjournal_article.R
Line 94 in 84a8fb4
Meaning that the new purled R file was not copied to the output dir unless the previous one was cleaned. No error or warning issued with
file.copy
in this case...That is nasty bug I think. But with an easy fix
Thanks @apreshill for finding this
The text was updated successfully, but these errors were encountered: