Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at rjournal template #2

Merged
merged 4 commits into from
Apr 15, 2014
Merged

First pass at rjournal template #2

merged 4 commits into from
Apr 15, 2014

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 14, 2014

Not perfect, but a start.

@@ -0,0 +1,53 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is now called skeleton.Rmd (to eliminate overlap in naming with pandoc templates).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed also that template.pdf got checked in

@hadley
Copy link
Member Author

hadley commented Apr 15, 2014

Made the changes you suggested and a few other small tweaks. There's still one outstanding issue with this template: it produces a pdf that looks right, but is not suitable for submission (because it's not in the right format).

I think the easiest way to do this is to have two output formats: one for previewing and one for submitting. Do you think rjournal_preview() and rjournal_submit() are reasonable names for these? The main difference is that submit would create a tex file, and preview a pdf.

We also need some way of templating skeleton files - i.e. RJwrapper.tex needs some way of being updated with values from the yaml metadata. Maybe I should just hook into pre_processor?

jjallaire added a commit that referenced this pull request Apr 15, 2014
First pass at rjournal template
@jjallaire jjallaire merged commit 91dc880 into master Apr 15, 2014
@jjallaire
Copy link
Member

I think those are good names for the different formats.

In terms of templating skeleton files, if you suggest a general approach to
this (e.g. based on whisker) I'd be happy to implement it.

On Tue, Apr 15, 2014 at 3:09 PM, Hadley Wickham notifications@github.comwrote:

Made the changes you suggested and a few other small tweaks. There's still
one outstanding issue with this template: it produces a pdf that looks
right, but is not suitable for submission (because it's not in the right
format).

I think the easiest way to do this is to have two output formats: one for
previewing and one for submitting. Do you think rjournal_preview() and
rjournal_submit() are reasonable names for these? The main difference is
that submit would create a tex file, and preview a pdf.

We also need some way of templating skeleton files - i.e. RJwrapper.texneeds some way of being updated with values from the yaml metadata. Maybe I
should just hook into pre_processor?

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-40521466
.

jjallaire pushed a commit that referenced this pull request Jul 3, 2016
+ add ability to include header .tex files
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants