-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font import helpers #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
cpsievert
commented
Mar 24, 2021
…r -- just for bundles)
… named arguments (i.e., font_collection(google = 'foo') => font_collection(font_google('foo')) )
cpsievert
force-pushed
the
font-import-helpers
branch
from
March 24, 2021 23:31
6538d5c
to
a601ae4
Compare
schloerke
approved these changes
Mar 26, 2021
schloerke
reviewed
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports
font_google()
,font_link()
, andfont_face()
from{bslib}
into{sass}
so that any{sass}
project can more easily import font files when declaringfont-family
Sass variables. The one catch is that you must use them inside named list variable declarations (as shown below). Note that by defaultfont_google()
will download, cache, and serve font files locally (so end users don't need an internet connection to render the font), but you can also import any remotely hosted web font withfont_link()
/font_face()
.