Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various speed improvements #98

Merged
merged 22 commits into from
Nov 17, 2021
Merged

Various speed improvements #98

merged 22 commits into from
Nov 17, 2021

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Nov 5, 2021

Various speed improvements inspired by investigation into rstudio/bslib#369

  1. Avoid validation of sass_layer() input when joining two layers together
  2. Avoid writing attachments on a sass() cache hit if output hasn't changed
  3. Use a faster way to get package installation/versions via {staticimports}
  4. Avoid other miscellaneous duplicate work in sass()

@cpsievert cpsievert marked this pull request as ready for review November 12, 2021 20:13
@cpsievert cpsievert requested a review from wch November 12, 2021 20:15
@cpsievert
Copy link
Contributor Author

@wch just FYI, the CI failures are also happening on the main branch -- I'll address those in a separate PR

@wch
Copy link
Collaborator

wch commented Nov 15, 2021

I think the functions need to be re-imported -- the versions in wch/staticimports#11 aren't exactly the same as what's in this PR.

@cpsievert
Copy link
Contributor Author

Failure to install on Windows 3.6 seem to be an Rtools issue that should be addressed in {shiny-workflows}, so merging

@cpsievert cpsievert merged commit 8852117 into main Nov 17, 2021
@cpsievert cpsievert deleted the fast-staticimports branch November 17, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants