-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various speed improvements #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
fast-staticimports
branch
from
November 8, 2021 23:40
50ef23a
to
ee301ff
Compare
cpsievert
force-pushed
the
fast-staticimports
branch
from
November 9, 2021 21:03
1d10d75
to
c41b314
Compare
@wch just FYI, the CI failures are also happening on the main branch -- I'll address those in a separate PR |
I think the functions need to be re-imported -- the versions in wch/staticimports#11 aren't exactly the same as what's in this PR. |
wch
approved these changes
Nov 15, 2021
Failure to install on Windows 3.6 seem to be an Rtools issue that should be addressed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various speed improvements inspired by investigation into rstudio/bslib#369
sass_layer()
input when joining two layers togethersass()
cache hit ifoutput
hasn't changed{staticimports}
sass()