Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shinyDeprecated() should probably warn(), not inform() #4013

Open
cpsievert opened this issue Mar 22, 2024 · 1 comment
Open

shinyDeprecated() should probably warn(), not inform() #4013

cpsievert opened this issue Mar 22, 2024 · 1 comment

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Mar 22, 2024

In #4007, we attempted to have shinyDeprecated() throw warn() instead of inform(), but we ended up reverting it (#4010) ended up causing reverse dependencies to have new problems. Here are those revdep/problems.md:

CLME

Run revdepcheck::cloud_details(, "CLME") for more info

Newly broken

  • checking whether package ‘CLME’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/CLME/new/CLME.Rcheck/00install.out’ for details.
    

In both

  • checking Rd files ... NOTE
    checkRd: (-1) clme.Rd:84: Escaped LaTeX specials: \&
    

epimdr2

Run revdepcheck::cloud_details(, "epimdr2") for more info

Newly broken

  • checking whether package ‘epimdr2’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/epimdr2/new/epimdr2.Rcheck/00install.out’ for details.
    

LifemapR

Run revdepcheck::cloud_details(, "LifemapR") for more info

Newly broken

  • checking re-building of vignette outputs ... ERROR
    Error(s) in re-building vignettes:
      ...
    --- re-building ‘runLifemapR.Rmd’ using rmarkdown
    
    Quitting from lines 51-55 [unnamed-chunk-3] (runLifemapR.Rmd)
    Error: processing vignette 'runLifemapR.Rmd' failed with diagnostics:
    cannot read from connection
    --- failed re-building ‘runLifemapR.Rmd’
    
    SUMMARY: processing the following file failed:
      ‘runLifemapR.Rmd’
    
    Error: Vignette re-building failed.
    Execution halted
    

MadanText

Run revdepcheck::cloud_details(, "MadanText") for more info

Newly broken

  • checking whether package ‘MadanText’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/MadanText/new/MadanText.Rcheck/00install.out’ for details.
    

In both

  • checking dependencies in R code ... NOTE
    Namespaces in Imports field not imported from:
      ‘shinythemes’ ‘topicmodels’
      All declared Imports should be used.
    

MadanTextNetwork

Run revdepcheck::cloud_details(, "MadanTextNetwork") for more info

Newly broken

  • checking whether package ‘MadanTextNetwork’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/MadanTextNetwork/new/MadanTextNetwork.Rcheck/00install.out’ for details.
    

In both

  • checking dependencies in R code ... NOTE
    Namespaces in Imports field not imported from:
      ‘ngram’ ‘shinythemes’ ‘topicmodels’
      All declared Imports should be used.
    

NetSimR

Run revdepcheck::cloud_details(, "NetSimR") for more info

Newly broken

  • checking whether package ‘NetSimR’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/NetSimR/new/NetSimR.Rcheck/00install.out’ for details.
    

SEA

  • Version: 2.0.1
  • GitHub: NA
  • Source code: https://github.com/cran/SEA
  • Date/Publication: 2022-03-30 07:30:12 UTC
  • Number of recursive dependencies: 39

Run revdepcheck::cloud_details(, "SEA") for more info

Newly broken

  • checking whether package ‘SEA’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/SEA/new/SEA.Rcheck/00install.out’ for details.
    

In both

  • checking installed package size ... NOTE
      installed size is 15.6Mb
      sub-directories of 1Mb or more:
        R  15.0Mb
    

SRTsim

  • Version: 0.99.6
  • GitHub: NA
  • Source code: https://github.com/cran/SRTsim
  • Date/Publication: 2023-01-13 15:20:02 UTC
  • Number of recursive dependencies: 164

Run revdepcheck::cloud_details(, "SRTsim") for more info

Newly broken

  • checking whether package ‘SRTsim’ can be installed ... WARNING
    Found the following significant warnings:
      Warning: `shiny::dataTableOutput()` is deprecated as of shiny 1.8.1.
    See ‘/tmp/workdir/SRTsim/new/SRTsim.Rcheck/00install.out’ for details.
    
@gadenbuie
Copy link
Member

gadenbuie commented Mar 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants