Barbara/update

[bborgesr]

This does the following:

• update to AdminLTE 2.3.8
• re-apply commit 73f6027 (trigger shown and hidden events for Shiny)
• re-apply commit e9e63d1 (serve fonts from local host)
• run grunt

I only re-applied those two commits because those are the only items left in the shiny-mods document.

Here are the two other possible mods that I think are no longer necessary (@wch correct me if I'm wrong):

• 02dd45b (attach event handler to overall sidebar menu)
• a31c58d (attach collapse event handler to document)

[wch]

Looking good - add a NEWS item? Also, you can bump the version to 0.5.3.9000.

[bborgesr]

For convenience, I'm adding the issue-specific test apps here, so we can go about future updates more seamlessly:

For issue #42 (fixed by 73f6027) -- the goal is to make sure that the box shows the plot when it is expanded:

library(shiny)
library(shinydashboard)

ui <- dashboardPage(
  dashboardHeader(),
  dashboardSidebar(
    sidebarMenu(
      menuItem("Inputs", icon = icon("bar-chart-o"), tabName = "tabOne"
      )
    )
  ),
  dashboardBody(
    tabItems(
      tabItem("tabOne",
        box(title = "Test Box One", 
          status = "success", 
          solidHeader = TRUE, 
          collapsible = TRUE,
          collapsed = TRUE,
          plotOutput("plot", height = 250),
          verbatimTextOutput("boxOneText")
        ),
        box(
          actionButton("go", "Go")
        )
      )
    )
  )
)

server <-  function(input, output) {
  output$plot <- renderPlot({
    cat(paste("plotting", input$go, "\n"))
    plot(rnorm(1 + input$go), rnorm(1 + input$go))
  })
  output$boxOneText <- renderText({
    paste("Go counter:", input$go)
  })
}

shinyApp(ui, server)

---

No test needed for #32 (fixed by e9e63d1), since it just requires the fonts to be hardcoded in the css file, rather than fetched from Google fonts.

---

For issue #54 (fixed by 02dd45b) -- the goal is to make sure these two scripts produce an identical-looking app (namely, both should show a menuItem that can be expanded to a menuSubItem):

Static UI:

library(shiny)
library(shinydashboard)
sidebar <- dashboardSidebar(
  sidebarMenu(menuItem("foo",
                        menuSubItem("foo_"), tabName = "tabfoo"))
)


ui <- dashboardPage(
  dashboardHeader(),
  sidebar,
  dashboardBody()
)

server <- function(input, output) {}

shinyApp(ui, server)

Dynamic UI:

library(shiny)
library(shinydashboard)
library(shiny)

sidebar <- dashboardSidebar(
  sidebarMenuOutput("sbMenu")
)


ui <- dashboardPage(
  dashboardHeader(),
  sidebar,
  dashboardBody()
)

server <- function(input, output) {
  output$sbMenu <- renderMenu({
    sidebarMenu(menuItem("foo", menuSubItem("foo_"), tabName = "tabfoo"))
    })
}

shinyApp(ui, server)

---

For issue #17 (fixed by a31c58d) -- the goal is to make sure the box is collapsible:

library(shiny)
body <- dashboardBody(
  uiOutput("ui")
)

server <- function(input, output) {  
  output$ui <- renderUI({
    box(title = "Collapse me",
        status = "warning", solidHeader = TRUE, collapsible = TRUE
    )
  })
}

shinyApp(
  ui = dashboardPage(
    dashboardHeader(),
    dashboardSidebar(),
    body
  ), 
  server = server
)

[bborgesr]

Since all three test apps above are working correctly, I think the update is good to go (and in the future, we don't have to worry anymore about commits 02dd45b and a31c58d, since it seems like those problems have now been fixed by Admin LTE itself).