Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.3 podspec is referencing the 0.8.2 source code. #53

Closed
bromoab opened this issue Feb 26, 2014 · 4 comments
Closed

0.8.3 podspec is referencing the 0.8.2 source code. #53

bromoab opened this issue Feb 26, 2014 · 4 comments

Comments

@bromoab
Copy link

bromoab commented Feb 26, 2014

The 0.8.3 pod spec file s.source statement is referencing the code tagged 0.8.2.

@RSully
Copy link
Owner

RSully commented Feb 26, 2014

Whoops! I've updated it in master, but I'm thinking I might need to tag 0.8.4 so it matches up in the versioning.

@RSully RSully closed this as completed Feb 26, 2014
@bromoab
Copy link
Author

bromoab commented Mar 2, 2014

Thanks for fixing it so promptly. When I built it, the 0.8.3 pod spec was not yet yet in the cocoa pods github based repository so I manually installed it my local repository. In your development flow would it be less error prone to use
tag => "#{s.version}"
rather than a hard coded string?

@RSully
Copy link
Owner

RSully commented Mar 2, 2014

perhaps tag = "v#{s.version}"?

I keep forgetting that those files are just Ruby - maybe a good idea. I'm not a very big CocoaPods user, but would that work?

@bromoab
Copy link
Author

bromoab commented Mar 3, 2014

Yes that would expand to "v0.8.3". #( ) is the string interpolation operator. It can take any expression not just a variable expansion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants