MMDBLOOKUP::Improvement:: allow mmdb to be reloaded on HUP signal #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 663a155 into 003ae3b - view on LGTM.com fixed alerts:
|
|
@frikilax gentle reminder: I think the CI fail has some valid points |
You're right, I didn't pay attention to those tests, will try to look into it shortly |
frikilax
force-pushed
the
mmdblookup_reload
branch
from
663a155
to
08d59e5
Compare
|
This pull request fixes 1 alert when merging 08d59e5 into 55b68be - view on LGTM.com fixed alerts:
|
|
looks like we (still?) have issues inside the code - memory leaks? |
|
Looks like a known issue with libmaxminddb, the leak is 0 bytes and was already suppressed in tests, but is popping again in another form |
frikilax
force-pushed
the
mmdblookup_reload
branch
from
08d59e5
to
f4ea547
Compare
|
This pull request fixes 1 alert when merging f4ea547 into 9188567 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of mmdblookup doesn't handle the mmdb file(s) safely, this improvement allows safe reloading of mmdb files after changing them, without having to restart Rsyslog