Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object tracking sample #8

Merged
merged 54 commits into from
May 28, 2020
Merged

Add object tracking sample #8

merged 54 commits into from
May 28, 2020

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented May 25, 2020

Checklists

  • I have read the CONTRIBUTING document.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

What does this implement/fix? Explain your changes.

カメラを使った物体追跡サンプルを追加しました。

Does this close any currently open issues?

関連issueはありません。

How has this been tested?

Raspi4 & ROS2 Dashing 環境で、実機動作を確認しました。

Any other comments?

ROS1のサンプル( https://github.com/rt-net/raspimouse_ros_examples )とコンセプトは同じですが、
コードや実際の動きに違いはあります。
とくに、PythonからC++に書き換えたこと、ROS1にはないlifecycleとcomponent機能を使ったことが大きな違いです。

@ShotaAk ShotaAk added the Type: Feature New Feature label May 25, 2020
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

句読点に表記ゆれが見られます。どちらでも(ピリオドとカンマでも)良いと思いますが、どちらかに統一するのが望ましいです。

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4l-utilsはpackage.xmlに書けばrosdep installできました。package.xmlに書いて手動でapt-get installしないという選択肢があると思います。

package.xml Show resolved Hide resolved
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image from Gyazo
画像処理は問題なくできていることを確認しました。

@ShotaAk
Copy link
Contributor Author

ShotaAk commented May 28, 2020

CIでNo CMAKE_C_COMPILER could be found.というエラーが出ていますが、
ローカルPCではcolcon buildcolcon testをパスしているのでマージします。

@ShotaAk ShotaAk merged commit 8f171ab into master May 28, 2020
@ShotaAk ShotaAk deleted the object_tracking branch May 28, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants