Use relative path for docroot on mkdocs #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to #3497, with this change the first build fails, probably we want to solve that issue before merging. |
RichardLitt
added
Needed: tests
|
@RichardLitt maybe add the Mkdocs label as well? |
stsewd
force-pushed
the
fix-docroot-path-mkdocks
branch
from
2649b90
to
537fb3f
Compare
|
The origaal blocking issue #3525 (comment) can't be replicated, so it's safe to continue, I only need to add a test, but I started some tests for mkdocs in #4184, so I would like to merge that PR first. |
stsewd
force-pushed
the
fix-docroot-path-mkdocks
branch
from
537fb3f
to
8bf99fc
Compare
stsewd
commented
Jun 7, 2018
| docs_path = os.path.join(self.root_path, docs_dir) | ||
| # The docs path is relative to the location | ||
| # of the mkdocs configuration file. | ||
| docs_path = os.path.join( |
There was a problem hiding this comment.
stsewd
added
PR: ready for review
and removed
Needed: tests
This was referenced Sep 25, 2018
|
@stsewd Is it needed something else here to merge this PR? If no, feel free to merge. |
|
We are good here, I'll do a last rebase to see if we don't need changes after the PR for mkdocs that was merged recently. Also, probably after tests on master pass. |
stsewd
force-pushed
the
fix-docroot-path-mkdocks
branch
from
8eeb728
to
60c31e7
Compare
|
We are all green again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While replicating #3515, I noticed that the other "edit" link (at the float version menu) was wrong #3515 (comment)
Fixes #1917