New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for docroot on mkdocs #3525

Merged
merged 5 commits into from Oct 2, 2018

Conversation

Projects
None yet
5 participants
@stsewd
Member

stsewd commented Jan 17, 2018

While replicating #3515, I noticed that the other "edit" link (at the float version menu) was wrong #3515 (comment)

Fixes #1917

@stsewd stsewd referenced this pull request Jan 17, 2018

Closed

View / Edit doesn't work #3515

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Jan 18, 2018

Member

Due to #3497, with this change the first build fails, probably we want to solve that issue before merging.

Member

stsewd commented Jan 18, 2018

Due to #3497, with this change the first build fails, probably we want to solve that issue before merging.

@marcelstoer

This comment has been minimized.

Show comment
Hide comment
@marcelstoer

marcelstoer Jan 21, 2018

Contributor

@RichardLitt maybe add the Mkdocs label as well?

Contributor

marcelstoer commented Jan 21, 2018

@RichardLitt maybe add the Mkdocs label as well?

@RichardLitt RichardLitt added the Mkdocs label Jan 22, 2018

@agjohnson agjohnson added this to the Mkdocs milestone Apr 10, 2018

@agjohnson agjohnson removed the Mkdocs label Apr 10, 2018

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Jun 6, 2018

Member

The origaal blocking issue #3525 (comment) can't be replicated, so it's safe to continue, I only need to add a test, but I started some tests for mkdocs in #4184, so I would like to merge that PR first.

Member

stsewd commented Jun 6, 2018

The origaal blocking issue #3525 (comment) can't be replicated, so it's safe to continue, I only need to add a test, but I started some tests for mkdocs in #4184, so I would like to merge that PR first.

@stsewd stsewd removed the Status: blocked label Jun 7, 2018

docs_path = os.path.join(self.root_path, docs_dir)
# The docs path is relative to the location
# of the mkdocs configuration file.
docs_path = os.path.join(

This comment has been minimized.

@stsewd

stsewd Jun 7, 2018

Member

@stsewd stsewd requested a review from rtfd/core Jun 7, 2018

@humitos

humitos approved these changes Jun 8, 2018

Looks good 👍

@humitos

This comment has been minimized.

Show comment
Hide comment
@humitos

humitos Oct 1, 2018

Member

@stsewd Is it needed something else here to merge this PR? If no, feel free to merge.

Member

humitos commented Oct 1, 2018

@stsewd Is it needed something else here to merge this PR? If no, feel free to merge.

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Oct 1, 2018

Member

We are good here, I'll do a last rebase to see if we don't need changes after the PR for mkdocs that was merged recently. Also, probably after tests on master pass.

Member

stsewd commented Oct 1, 2018

We are good here, I'll do a last rebase to see if we don't need changes after the PR for mkdocs that was merged recently. Also, probably after tests on master pass.

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Oct 2, 2018

Member

We are all green again

Member

stsewd commented Oct 2, 2018

We are all green again

@stsewd stsewd merged commit 5ffb6bc into rtfd:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:fix-docroot-path-mkdocks branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment