New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extend Translation and Subproject form logic from corporate #3937

Merged
merged 2 commits into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Apr 11, 2018

There is no changes in the logic, just make these two forms extendable from Corporate site since we need to change some logic regarding the Organizations permissions.

@agjohnson

The old style settings was to create a new setting for every override. The new pattern is to user the override classes mapping instead.

@@ -281,6 +282,11 @@ def get_subproject_queryset(self):
return queryset
class ProjectRelationshipForm(SettingsOverrideObject):
_default_class = ProjectRelationshipBaseForm
_override_setting = 'PROJECT_RELATIONSHIP_FORM'

This comment has been minimized.

@agjohnson

agjohnson Apr 11, 2018

Contributor

We don't use individual settings anymore, this is legacy. See the override classes setting instead.

@@ -563,6 +569,11 @@ def save(self):
return project
class TranslationForm(SettingsOverrideObject):
_default_class = TranslationBaseForm
_override_setting = 'PROJECT_TRANSLATION_FORM'

This comment has been minimized.

@agjohnson

agjohnson Apr 11, 2018

Contributor

Same here

@agjohnson agjohnson added this to the 2.4 milestone Apr 11, 2018

@agjohnson agjohnson merged commit 6bd1c68 into master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/corporate/extend-forms branch Apr 12, 2018

xrmx added a commit to italia/docs.italia.it that referenced this pull request Apr 17, 2018

Allow extend Translation and Subproject form logic from corporate (rt…
…fd#3937)

* Allow extend Translation and Subproject form logic from corporate

* Remove old style setting override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment