Allow extend Translation and Subproject form logic from corporate #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
requested changes
Apr 11, 2018
readthedocs/projects/forms.py
Outdated
| @@ -281,6 +282,11 @@ def get_subproject_queryset(self): | |||
| return queryset | |||
|
|
|||
|
|
|||
| class ProjectRelationshipForm(SettingsOverrideObject): | |||
| _default_class = ProjectRelationshipBaseForm | |||
| _override_setting = 'PROJECT_RELATIONSHIP_FORM' | |||
There was a problem hiding this comment.
We don't use individual settings anymore, this is legacy. See the override classes setting instead.
readthedocs/projects/forms.py
Outdated
| @@ -563,6 +569,11 @@ def save(self): | |||
| return project | |||
|
|
|||
|
|
|||
| class TranslationForm(SettingsOverrideObject): | |||
| _default_class = TranslationBaseForm | |||
| _override_setting = 'PROJECT_TRANSLATION_FORM' | |||
agjohnson
approved these changes
Apr 12, 2018
xrmx
pushed a commit
to italia/docs.italia.it
that referenced
this pull request
Apr 17, 2018
…adthedocs#3937) * Allow extend Translation and Subproject form logic from corporate * Remove old style setting override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no changes in the logic, just make these two forms extendable from Corporate site since we need to change some logic regarding the Organizations permissions.