-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove search autosync from tests so local tests work #4675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes my tests locally 👍
I think it will not work if you want to run the search tests. |
readthedocs/search/tests/test_api.py
Outdated
@@ -9,6 +11,7 @@ | |||
|
|||
@pytest.mark.django_db | |||
@pytest.mark.search | |||
@override_settings(ELASTICSEARCH_DSL_AUTOSYNC=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be used with unittest only! we need to use pytest here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how do you do it with pytest?
This needs additional work to then also fix the travis tests.