Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken url on sphinx projects #4696

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Fix broken url on sphinx projects #4696

merged 3 commits into from
Oct 2, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 1, 2018

Fix #4671

@stsewd stsewd requested a review from a team October 1, 2018 19:15
stsewd
stsewd commented Oct 1, 2018
View reviewed changes
readthedocs/rtd_tests/tests/test_doc_builder.py Outdated
params = base_sphinx.get_config_params()
self.assertEqual(
params['conf_py_path'],
'/docs/'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what else to test from params.

stsewd
stsewd commented Oct 1, 2018
View reviewed changes
readthedocs/rtd_tests/tests/test_doc_builder.py
python_env=python_env,
)

for value, expected in (('conf.py', '/'), ('docs/conf.py', '/docs/')):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use pytests parametrize here :(

@JiaweiZhuang JiaweiZhuang mentioned this pull request Oct 1, 2018
Closed
@stsewd
Copy link
Member Author

stsewd commented Oct 1, 2018

Travis failure is for search stuff

@stsewd stsewd mentioned this pull request Oct 2, 2018
Closed
agjohnson
agjohnson approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agjohnson agjohnson merged commit 4c2fe1e into readthedocs:master Oct 2, 2018
@stsewd stsewd deleted the fix-broken-url-sphinx branch October 2, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @agjohnson