New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken url on sphinx projects #4696

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@stsewd
Member

stsewd commented Oct 1, 2018

Fix #4671

@stsewd stsewd requested a review from rtfd/core Oct 1, 2018

python_env=python_env,
)
for value, expected in (('conf.py', '/'), ('docs/conf.py', '/docs/')):

This comment has been minimized.

@stsewd

stsewd Oct 1, 2018

Member

We can't use pytests parametrize here :(

@stsewd

stsewd Oct 1, 2018

Member

We can't use pytests parametrize here :(

@stsewd

This comment has been minimized.

Show comment
Hide comment
@stsewd

stsewd Oct 1, 2018

Member

Travis failure is for search stuff

Member

stsewd commented Oct 1, 2018

Travis failure is for search stuff

@agjohnson

LGTM!

@agjohnson agjohnson merged commit 4c2fe1e into rtfd:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:fix-broken-url-sphinx branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment