Reapply the Elastic Search upgrade to master
#4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
added
the
PR: work in progress
5 tasks
ericholscher
force-pushed
the
search-reapply
branch
3 times, most recently
from
9857e01
to
2ae0310
Compare
This is a squashed commit of all previous changes.
ericholscher
force-pushed
the
search-reapply
branch
from
2ae0310
to
6a451ec
Compare
index project asynchronously
ericholscher
force-pushed
the
search-reapply
branch
2 times, most recently
from
b3f24b1
to
12de58b
Compare
ericholscher
force-pushed
the
search-reapply
branch
from
b38575b
to
bb4db91
Compare
This fixes an XSS issue that we were hitting, where search results were showing HTML to users.
stsewd
reviewed
Jan 24, 2019
readthedocs/search/tests/test_xss.py
Outdated
|
|
||
| @pytest.mark.django_db | ||
| @pytest.mark.search | ||
| class TestXSS(object): |
There was a problem hiding this comment.
No need to inheritance from object anymore
|
Congrats @safwanrahman! |
|
😄 Thanks @ericholscher for mentoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of the revert, so that we have a place to track the search code.
We should also push any testing for performance and other tweaks here.