Move file validations out of the config module #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validations will be executed in build time. This will unblock users with dependencies in submodules. Closes readthedocs#5238
|
I still need to check for the validations before using files in the build or just left the builder fail if the error is good enough. |
|
Feels like I could start testing this after #5609 (also, there is a lot of code that makes the validation in different parts, but the above PR with this one is a start) |
|
#5609 is blocked bc we need to inform users first, but this PR isn't blocked, just need clean up for some functions making redundant steps, that can be done later. |
stsewd
removed
the
PR: work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validations will be executed in build time.
This will unblock users with dependencies in submodules.
Closes #5238