Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file validations out of the config module #5627

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Apr 24, 2019

This validations will be executed in build time.
This will unblock users with dependencies in submodules.

Closes #5238

This validations will be executed in build time.
This will unblock users with dependencies in submodules.

Closes readthedocs#5238
@stsewd
Copy link
Member Author

@stsewd stsewd commented Apr 24, 2019

I still need to check for the validations before using files in the build or just left the builder fail if the error is good enough.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Apr 24, 2019

Feels like I could start testing this after #5609

(also, there is a lot of code that makes the validation in different parts, but the above PR with this one is a start)

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 28, 2019

#5609 is blocked bc we need to inform users first, but this PR isn't blocked, just need clean up for some functions making redundant steps, that can be done later.

@stsewd stsewd requested a review from May 28, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense 👍

@ericholscher ericholscher merged commit c79dbe4 into readthedocs:master Jun 4, 2019
1 check passed
@stsewd stsewd deleted the move-file-validations-out-of-the-config-module branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants