Redirect project slugs with underscores #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Apr 25, 2019
|
probably we could add a test with two |
|
Looks good enough for me. This is legacy code, so we don't need too many tests, it only needs to work for the projects in the past. |
delete-merged-branch
bot
deleted the
davidfischer/project-slug-underscore-redirects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR related to data cleanup. It redirects all requests to
/project/<project_slug>/*whereproject_slugcontains an underscore to a version of the project slug with a-._in them. New projects already can't have an underscore in their slug. We should modify the offending project slugs._but I think that's ok.Related to: #5633