Fix mkdocs relpath #5749
Merged
Fix mkdocs relpath #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After readthedocs#5377 The code calling the config module is in charge of getting the full path.
|
I encountered this error here. I was able to reproduce it on the same repo locally. This PR did fix the issue. |
stsewd
commented
May 31, 2019
| @@ -248,7 +248,7 @@ def build(self): | |||
| '--site-dir', | |||
| self.build_dir, | |||
| '--config-file', | |||
| self.yaml_file, | |||
| os.path.relpath(self.yaml_file, self.root_path), | |||
There was a problem hiding this comment.
One test was expecting this call to be relative to the checkout path, but with the new change this was a full path.
Relative path is shorter to show in the output and we are already setting the cwd to the checkout path, so we are fine.
|
I also checked all the usages of |
davidfischer
approved these changes
May 31, 2019
|
@stsewd do you think this should be hotfixed today? |
|
@ericholscher yeah, it affects people using mkdocs with a rtd configuration file. Which I think are most of our users now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5377
The code calling the config module is in charge of getting the full
path.