Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract hash ourselves to work around difference between Fx and other browsers #615

Closed
wants to merge 2 commits into from

Conversation

jessetan
Copy link
Contributor

Should fix #495.

@davidfischer
Copy link
Contributor

When I use Firefox 59 and Chrome 65, I'm seeing exactly the same result for window.location.hash even when the hash contains unicode.

@jessetan
Copy link
Contributor Author

@davidfischer I can also no longer reproduce Firefox' old, buggy behavior.
I've asked the original reporter in #495 if this is still an issue.

DO NOT MERGE YET

Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for feedback from bug report

@jessetan
Copy link
Contributor Author

This PR did not solve the original issue, closing.

@jessetan jessetan closed this Apr 30, 2018
@stsewd stsewd deleted the fix-495 branch December 3, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation tree collapse if page link's anchor is unicode text.
3 participants