Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css classes not rendering correctly #563

Closed
Confidenceman02 opened this issue Jan 9, 2022 · 0 comments · Fixed by #562
Closed

Css classes not rendering correctly #563

Confidenceman02 opened this issue Jan 9, 2022 · 0 comments · Fixed by #562

Comments

@Confidenceman02
Copy link
Contributor

Confidenceman02 commented Jan 9, 2022

Context

As as result of fixing #543 I introduced another probably more severe bug. Using className as the value to VirtualDom.attrbute incorrectly renders the classname attribute.

For non svg dom nodes it renders as classname and for svg nodes is renders as className. Both are incorrect syntax and means no styles are actually applied.

classnames

Fix

Using class fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant