simulation proxy extra functionality #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs testing.
time that's displayed on the GUI. Could be handy?
simulation time is big enough to store a uint64_t.
Fixed conflicts between my stuff and old stuff. Conflicts: libstageplugin/p_simulation.cc
|
I pulled this today and tweaked it just a bit before committing to my master. I changed the name of the property from "simtime" or "sim_time" to simply "time", and simplified the code a little. It might have been a better strategy to modify Player's sim interface to include this functionality, but that's a little more complex. This will work for anyone who really needs it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to be able to read the simulated time from the simulation and nothing seemed to be able to do that, so I added some functionality to SimulationProxy::GetProperty so that you can retrieve the simulation time.
It might be useful to others, so I'm submitting the new stuff for inclusion in the next release.
Jenny