Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionBarSherlock 4.1.0 has been released #10

Closed
candrews opened this issue Jun 3, 2012 · 4 comments
Closed

ActionBarSherlock 4.1.0 has been released #10

candrews opened this issue Jun 3, 2012 · 4 comments

Comments

@candrews
Copy link

candrews commented Jun 3, 2012

ActionBarSherlock 4.1.0 has been released. You should probably bump the dependency version in your pom.xml, and test against it to make sure everything still works okay.

Thanks!

@rtyley
Copy link
Owner

rtyley commented Jun 3, 2012

I'm currently testing Agit against ABS 4.1.0, looks good there, though obviously that doesn't exercise all ABS functionality.

I'm not intending to release a version-bump of roboguice-sherlock on this version of ABS tho, unless you know of a specific issue that makes that necessary? Users who want to upgrade can simply update the poms of their own projects with the specific ABS dependency, rather than waiting for me to push out a redundant release.

The code in roboguice-sherlock is just code that extends ABS classes, it doesn't duplicate them, and it also doesn't reference any ABS functionality - it just overrides the normal Activity/Fragment method definitions, so there's limited potential for an ABS upgrade to break things (rather more potential with a roboguice upgrade).

However, if you know of a specific issue that needs addressing, please let me know and we can get a new release pushed out.

@JakeWharton
Copy link
Contributor

The minor version bump was more representative of the significance of a change rather than signifying a large number of changes. Functionally there is almost nothing different from 4.0.2 except moving a few methods to a class in a different package.

@Wavesonics
Copy link

ABS 4.2.0 has now been released, is there any need for roboguice to update? I'm considering using this lib, but just want to be sure it's being maintained.

@rtyley
Copy link
Owner

rtyley commented Oct 16, 2012

I've not yet evaluated roboguice-sherlock against ABS 4.2.0, but as I said above, the code in roboguice-sherlock is just code that extends ABS classes, it doesn't duplicate them, and it also doesn't reference any ABS functionality - it just overrides the normal Activity/Fragment method definitions with duplication of RoboGuice logic. So there's limited potential for an ABS upgrade to break things (rather more potential with a roboguice upgrade).

rtyley added a commit that referenced this issue Oct 25, 2012
Not essential to update, but might as well point to current version.
@rtyley rtyley closed this as completed Oct 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants