Merge branch 'next' of git://github.com/rubberduck-vba/Rubberduck int…

…o fixStringSheet

Rubberduck.CodeAnalysis/Inspections/Concrete/ParameterCanBeByValInspection.cs

@@ -19,6 +19,7 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete
     /// a parameter that is passed by reference (implicitly, or explicitly ByRef) makes it ambiguous from the calling code's standpoint, whether the 
     /// procedure might re-assign these ByRef values and introduce a bug.
     /// </why>
+    /// <remarks>For performance reasons, this inspection will not flag a parameter that is passed as an argument to a procedure that also accepts it ByRef.</remarks>
     /// <example hasResult="true">
     /// <module name="MyModule" type="Standard Module">
     /// <![CDATA[
@@ -39,6 +40,21 @@ namespace Rubberduck.CodeAnalysis.Inspections.Concrete
     /// ]]>
     /// </module>
     /// </example>
+    /// <example hasResult="false">
+    /// <module name="MyModule" type="Standard Module">
+    /// <![CDATA[
+    /// Option Explicit
+    /// Public Sub DoSomething(ByVal foo As long, ByRef bar As Long)
+    ///     DoSomethingElse bar ' ByRef argument will not be flagged
+    ///     Debug.Print foo, bar
+    /// End Sub
+    ///
+    /// Private Sub DoSomethingElse(ByRef wouldNeedRecursiveLogic As Long)
+    ///    Debug.Print wouldNeedRecursiveLogic
+    /// End Sub
+    /// ]]>
+    /// </module>
+    /// </example>
     internal sealed class ParameterCanBeByValInspection : DeclarationInspectionBase
     {
         public ParameterCanBeByValInspection(IDeclarationFinderProvider declarationFinderProvider)

Rubberduck.Core/Properties/Resources.resx

@@ -117,4 +117,8 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
+  <data name="Splash2021f" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\Resources\Splash2021f.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
 </root>

Rubberduck.Core/Rubberduck.Core.csproj

@@ -5,7 +5,7 @@
     <AssemblyName>Rubberduck.Core</AssemblyName>
     <Title>Rubberduck.Core</Title>
     <Product>Rubberduck.Core</Product>
-    <Copyright>Copyright © 2014-2019</Copyright>
+    <Copyright>Copyright © 2014-2021</Copyright>
     <ProjectGuid>{A1587EAC-7B54-407E-853F-4C7493D0323E}</ProjectGuid>
     <DocumentationFile>bin\Debug\Rubberduck.Core.xml</DocumentationFile>
     <!-- Disable "Missing XML documentation" warning (CS1591) -->
@@ -91,4 +91,17 @@
       <Version>2.0.20525</Version>
     </PackageReference>
   </ItemGroup>
+  <ItemGroup>
+    <Compile Update="Properties\Resources.Designer.cs">
+      <DesignTime>True</DesignTime>
+      <AutoGen>True</AutoGen>
+      <DependentUpon>Resources.resx</DependentUpon>
+    </Compile>
+  </ItemGroup>
+  <ItemGroup>
+    <EmbeddedResource Update="Properties\Resources.resx">
+      <Generator>ResXFileCodeGenerator</Generator>
+      <LastGenOutput>Resources.Designer.cs</LastGenOutput>
+    </EmbeddedResource>
+  </ItemGroup>
 </Project>

Rubberduck.Core/UI/Splash2021.cs

@@ -0,0 +1,27 @@
+using System;
+using System.Collections.Generic;
+using System.ComponentModel;
+using System.Data;
+using System.Drawing;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using System.Windows.Forms;
+
+namespace Rubberduck.UI
+{
+    public partial class Splash2021 : Form
+    {
+        public Splash2021()
+        {
+            InitializeComponent();
+#if DEBUG
+            VersionLabel.Text = $"Version {GetType().Assembly.GetName().Version} (debug)";
+#else
+            VersionLabel.Text = $"Version {GetType().Assembly.GetName().Version}";
+#endif
+            VersionLabel.Parent = pictureBox1;
+            VersionLabel.BackColor = Color.Transparent;
+        }
+    }
+}