Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter is passed ByRef implicitly #40

Closed
retailcoder opened this issue Nov 16, 2014 · 3 comments
Closed

Parameter is passed ByRef implicitly #40

retailcoder opened this issue Nov 16, 2014 · 3 comments
Labels
feature-inspections
Milestone
Code Inspections

Comments

@retailcoder
Copy link
Member

[Suggestion]

If parameter is assigned in the body of the procedure, Rubberduck should suggest passing ByRef explicitly; if parameter is not assigned, Rubberduck should suggest passing it ByVal.
@retailcoder retailcoder added this to the Code Inspections milestone Nov 16, 2014
@retailcoder
Copy link
Member Author

implemented:

  • Inspection
  • QuickFix 1: Pass parameter by reference explicitly.
  • QuickFix 2: Pass parameter by value.

@retailcoder
Copy link
Member Author

off-by-one fixed, this is ready to implement.

@retailcoder
Copy link
Member Author

Closing for now; Code Inspections UI leaves it up to the user to select which fix to apply.

retailcoder added a commit that referenced this issue Feb 20, 2016
@retailcoder
Merge pull request #40 from rubberduck-vba/next
028efc1 
sync with merged PR's in main repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-inspections
Projects
None yet
Milestone
Code Inspections
Development

No branches or pull requests
2 participants
@rubberduck203 @retailcoder