Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Inspections: Its not possible to explore the contributors to a consolidated Warning #4870

Closed
ghost opened this issue Mar 21, 2019 · 3 comments · Fixed by #4898
Closed
Labels
bug Identifies work items for known bugs feature-inspections

Comments

@ghost
Copy link

ghost commented Mar 21, 2019

Rubberduck version information

Version 2.4.0.4618
OS: Microsoft Windows NT 10.0.17763.0, x64
Host Product: Microsoft Office x64
Host Version: 16.0.11425.20140
Host Executable: WINWORD.EXE

I have an inspection warning

Object Variable assignment requires 'Set' Keyword (281) results.

Its doesn't appear to be possible to expand this item so I can't investigate what is causing the problem. The code in question compiles without any issues.
Now I could allow Rubberduck to Fix this issue for me but........

Its also worth noting that this Warning does NOT appear in the list of items when you dump the Code Inspection to the clipboard.

@ghost ghost added the bug Identifies work items for known bugs label Mar 21, 2019
@ghost
Copy link
Author

ghost commented Mar 21, 2019

I tried to implement fix all occurences but this highlighted something odd.

If I refresh RubberDuck and select the 'Set' error message above I don't get any messages at the foot of the window.

If I click on another message 'Function is not used' I get the appropriate information about why the error is flagged and possible options to fix the problem

If I then go back to the ' Set' error message , the ' Function not used' warning is not cleared (hence my thinking I could 'fix' all occurrences.

Furthermore, if I then double click the 'set' error message I get taken to the line of code that refers to the 'Function not used' error.

@daFreeMan
Copy link
Contributor

The original issue - grouped inspections - is a known and old and irritating issue, therefore a dupe, but I can't find the/an older one.

Not sure about what you've got in the 2nd issue

@Vogel612
Copy link
Member

Issues around aggregated inspection results are mostly quite aged by now.. I'm not even sure all of these still apply, but we currently have open the issues: #4561, #3597, #3172 and #2900. There is probably some overlap between these...

@MDoerner MDoerner added bug Identifies work items for known bugs and removed bug Identifies work items for known bugs labels Mar 21, 2019
Vogel612 added a commit to Vogel612/Rubberduck that referenced this issue Apr 4, 2019
The original rationale for inspection result aggregation was the excessive memory use
when displaying them. Since the rework of the Inspections view, this is no longer an issue.

As such aggregation, which has multiple issues is removed in this commit. This change makes
the following issues completely obsolete and fixes them that way:

fixes rubberduck-vba#4561, fixes rubberduck-vba#3597, fixes rubberduck-vba#3172, fixes rubberduck-vba#2900, fixes rubberduck-vba#4870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs feature-inspections
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants