Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translations for 2.4.1 #4860

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

MDoerner
Copy link
Contributor

No description provided.

@MDoerner MDoerner requested a review from Vogel612 March 17, 2019 13:57
Copy link
Member

@Vogel612 Vogel612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the non-honorific form use for the refactoring suggestions is a break of tone compared to the existing formulations.

Also I'm not a huge fan of avoiding umlauts in the test templates, but I can see where you're coming from.

<value>Negative Zeilennummern können nur im Hexadezimalformat eingegeben werden, welches der VBE in negative Dezimalzahlen wandelt. Wird der Programmcode kopiert, mach die negative Dezimalzahl als Zeilennummer ihn illegal.</value>
</data>
<data name="OnErrorGoToMinusOneInspection" xml:space="preserve">
<value>Hierbei handelt es sich um ein schlecht dokumentiertes Feature: Im Normallfall wird der Fehlerspeicher gelehrt und jegliche Fehlerbehandlung deaktiviert. Sollte allerdings -1 als Zeilennummer vorhanden sein, kann diese als Marker der zu verwendenden Fehlerbehandlung interpretiert werden.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"geleert"

@MDoerner
Copy link
Contributor Author

Hm, I did not look up the whether we use honorific or non-honorific form. I'll change it to honorific.

I avoided the umlauts because they can actually break the project when viewed with the wrong system language.

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #4860 into next will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #4860      +/-   ##
==========================================
- Coverage   64.54%   64.53%   -<.01%     
==========================================
  Files        1027     1027              
  Lines       35436    35436              
==========================================
- Hits        22869    22868       -1     
- Misses      12567    12568       +1
Impacted Files Coverage Δ
Rubberduck.Parsing/VBA/RubberduckParserState.cs 63.5% <0%> (-0.24%) ⬇️

@Vogel612 Vogel612 merged commit 12a4328 into rubberduck-vba:next Mar 19, 2019
@Vogel612 Vogel612 mentioned this pull request Mar 19, 2019
3 tasks
@MDoerner MDoerner deleted the GermanTranslationsFor241 branch April 18, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants