Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing workload configs #5745

Merged
merged 9 commits into from
May 26, 2021
Merged

Conversation

retailcoder
Copy link
Member

@retailcoder retailcoder commented Apr 23, 2021

Adds a new wizard page to the installer with a checkbox to optionally seed %appdata%\Rubberduck\rubberduck.config with a default configuration file that disables a number of features and inspections, documented in a readme.md file.

new installer wizard page

@retailcoder
Copy link
Member Author

Somehow the checkbox value is refusing to read into its variable, not sure what I'm doing wrong here.

@retailcoder retailcoder added PR-Status: WIP Pull request is work-in-progress, more commits should be expected. help wanted labels Apr 24, 2021
@PhilCattivocaratere
Copy link
Contributor

Please forgive if I cannot refere directly to the file but I am not so good with GitHub (and not only)
In my opinion the problem is in this line of Rubberduck.Installer.Build.iss
Source: "{#SourcePath}\WorkloadConfigs\Legacy\rubberduck.config"; DestDir: "{userappdata}\{#AppName}"; Flags: ignoreversion replacesameversion; Check: CheckUseLegacyWorkloadConfig;

Check parameter is evaluated before the wizard page where you can select the checkbox is displayed, so the installer will never copy rubberduck.config because CheckUseLegacyWorkloadConfig is always false.
Coping should be called here

    if WorkloadOptionPage.Values[0] then
    begin
      Log('Legacy workload initial config was requested and will be copied to the destination folder.');
      // now you can copy Rubberduck.config
    end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted PR-Status: WIP Pull request is work-in-progress, more commits should be expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants