Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling issue when loading images in onBindViewHolder #207

Closed
Anuragjain01 opened this issue May 9, 2024 · 9 comments · Fixed by #209
Closed

Scrolling issue when loading images in onBindViewHolder #207

Anuragjain01 opened this issue May 9, 2024 · 9 comments · Fixed by #209
Labels
help wanted Extra attention is needed

Comments

@Anuragjain01
Copy link

No description provided.

@rubensousa
Copy link
Owner

rubensousa commented May 9, 2024

Hello. Can you please provide detailed information for this issue? I can't help without knowing more about what's wrong

@Anuragjain01
Copy link
Author

Hi @rubensousa i am using DpadRecylerView demo also using in my project untill i did not use image on card its working fine but when i added image
In itemViewHolder in your sample. getting stuck
textView?.text = item.toString()
imageView?.let {
Glide
.with(it.context)
.load("https://raw.githubusercontent.com/Anuragjain01/image_folder/main/01.png")
.diskCacheStrategy(DiskCacheStrategy.ALL)
.skipMemoryCache(false)
.centerCrop()
.into(it)

vertical_scroll_not_smooth.mp4
vertical_scroll_not_smooth.mp4

@rubensousa
Copy link
Owner

Can you please commit that state to your fork and share the link here? I will have a look, but it looks like your onBindViewHolder calls are too heavy

@rubensousa rubensousa added the help wanted Extra attention is needed label May 18, 2024
@homayoonahmadi
Copy link

Hi there, I can confirm this behavior, I'm seeing it in my project too

@homayoonahmadi
Copy link

I have a grid of items with spanCount that includes section headers, this happens when I navigate between sections (especially when I go up), but inside a section (if the section has multiple rows) it doesn't happen

@rubensousa
Copy link
Owner

@homayoonahmadi can you share a sample that reproduces the issue?

@rubensousa
Copy link
Owner

@homayoonahmadi @Anuragjain01 Can you please try this: setLayoutWhileScrollingEnabled(false) and let me know if it solves the issue?

@homayoonahmadi
Copy link

Using setLayoutWhileScrollingEnabled(false) didn't help me. I will share a sample when I got a chance.

@rubensousa rubensousa changed the title Having issue when pressing Dpad Down or up have suck overlay Scrolling issue when loading images in onBindViewHolder May 30, 2024
@rubensousa
Copy link
Owner

@homayoonahmadi @Anuragjain01 please try out 1.3.0-alpha03 and let me know if the issue is still there. If that's the case, I'm going to need a sample because I couldn't reproduce this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants