Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Running spec/ruby/core for 1.8 fails #1652

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

michalbugno commented Apr 5, 2012

I'm new to Rubinius and not sure if I reproduced it ok, but when I tried to run ./bin/mspec ci -T -X18 spec/ruby/core/ (which I believe is a subset of specs which should work for rubinius 1.8.X) I got two errors:

  1. Syntax on :! : MRI allows it and in RBX you have to :"!" -- this looks like a bug?
  2. BasicObject fixtures which should not load in 1.8 (no BO there)
Contributor

michalbugno commented Apr 9, 2012

The :! is not a bug actually, MRI1.9 handles it but MRI1.8 does not. Still the BasicObject should not load for 1.8

Michal Bugno BasicObject fixtures should not load in 1.8
Fix to :! parser error in BasicObject specs
adf9670
Member

jfirebaugh commented Apr 17, 2012

The BasicObject specs are normally excluded on 1.8 via rbx.1.8.mspec. @brixen, is it intended that mspec command line arguments override any excludes in the .mspec file?

This pull request passes (merged adf9670 into f4beee0).

Owner

brixen commented May 1, 2012

If you want to run all the specs under spec/ruby/core, use the :core psuedo dir that mspec provides.

E.g. bin/mspec ci -T -X18 :core

@brixen brixen closed this May 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment