Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax context wording rule (allow with and without) #28

Closed
Darhazer opened this issue Aug 9, 2018 · 0 comments
Closed

Relax context wording rule (allow with and without) #28

Darhazer opened this issue Aug 9, 2018 · 0 comments
Labels
help wanted Beginner-friendly contribution

Comments

@Darhazer
Copy link
Member

Darhazer commented Aug 9, 2018 •
edited by pirj
Loading

Currently the style guide says that context should always start with when, but with and without are also good descriptions of context and they are allowed by default in rubocop-rspec.

So I suggest to add them to the style guide as well.

rubocop-rspec pull request
betterspecs pull request

Rationale:

# not so hot
context 'with sprinkles' ...
context 'when there are no sprinkles on top' ...

# better
context 'with sprinkles' ...
context 'without sprinkles' ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Beginner-friendly contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirj @Darhazer