Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Capybara/CurrentPathExpectation when matcher's argument is a method with a argument and no parentheses #39

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 12, 2023

Fix: #37


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah
Copy link
Member Author

ydah commented Apr 13, 2023

Oh, the GHA workflow in Yamllint is not running 🤔

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah
Copy link
Member Author

ydah commented Apr 14, 2023

@bquorning @pirj @Darhazer
Perhaps re-configuring the workflow settings from the required status checks might solve the problem. Can someone please reconfigure Yamllint as I don't seem to have the authority to change it?

スクリーンショット 2023-04-14 0 37 00

Something similar was happening:.
rubocop/rubocop#11714 (comment)

@bquorning
Copy link
Contributor

Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesn’t work well on required checks.

So should we make the linter checks not required, or somehow make them “successful” if they are not run?

@ydah
Copy link
Member Author

ydah commented Apr 16, 2023

Yeah, in #33 the linter cops were configured to only run if a .md or .yml were changed. I guess that doesn’t work well on required checks.

So should we make the linter checks not required, or somehow make them “successful” if they are not run?

Ah! Indeed it is 😱 Sorry, I overlooked the case where the merge was blocked.
It does not seem possible to assume success if it is not executed, so it would be better to set it to not required or to stop the control by paths.

…en matcher's argument is a method with a argument and no parentheses

Fix: #37
@ydah ydah merged commit 0eed12c into main Apr 17, 2023
@ydah ydah deleted the fix/37 branch April 17, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocorrect for expect(current_path) moves method argument when parens are absent
3 participants