-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CodeSpell GitHub Action #11714
Use CodeSpell GitHub Action #11714
Conversation
Thanks! |
@nschonni I've noticed that the new action tends to get stuck (it didn't finish for any PR since yesterday). Can you please look into this? |
Can you point to where it's stalling out, I'm not seeing any on https://github.com/rubocop/rubocop/actions/workflows/spell_checking.yml |
If you mean stalled like on rubocop/rubocop-minitest#246, that's related to the branch rules looking for a name related to the old job name |
It seemed to have stalled here when I was looking at this PR, but now I see it seemed to have passed https://github.com/rubocop/rubocop/actions/runs/4464137982/jobs/7840005670 Anyways, not a big deal - I'll keep an eye out for this. |
It looks like there is a job that never ends, probably because an old spell check job is specified as a required job, although it is also occurring below. |
I've removed old workflow from status checks that are required. So, that issue has been resolved. |
The project offers a GitHub Action directly, so swapping out the custom PIP install setup
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.