Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CodeSpell GitHub Action #11714

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Conversation

nschonni
Copy link
Contributor

The project offers a GitHub Action directly, so swapping out the custom PIP install setup


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit c3d2bee into rubocop:master Mar 19, 2023
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 19, 2023

Thanks!

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 20, 2023

@nschonni I've noticed that the new action tends to get stuck (it didn't finish for any PR since yesterday). Can you please look into this?

@nschonni
Copy link
Contributor Author

Can you point to where it's stalling out, I'm not seeing any on https://github.com/rubocop/rubocop/actions/workflows/spell_checking.yml

@nschonni
Copy link
Contributor Author

If you mean stalled like on rubocop/rubocop-minitest#246, that's related to the branch rules looking for a name related to the old job name Check spelling of all files with codespell (3.8) rather than the the new one

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 20, 2023

It seemed to have stalled here when I was looking at this PR, but now I see it seemed to have passed https://github.com/rubocop/rubocop/actions/runs/4464137982/jobs/7840005670 Anyways, not a big deal - I'll keep an eye out for this.

@ydah
Copy link
Member

ydah commented Mar 20, 2023

It looks like there is a job that never ends, probably because an old spell check job is specified as a required job, although it is also occurring below.

New
image

Old
image

@koic
Copy link
Member

koic commented Mar 20, 2023

I've removed old workflow from status checks that are required. So, that issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants