Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExplicitOnly configuration option to FactoryBot/ConsistentParenthesesStyle, FactoryBot/CreateList and FactoryBot/FactoryNameStyle #18

Merged
merged 5 commits into from
May 14, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented May 6, 2023

Follow up: rubocop/rubocop-rspec#1482 (comment)
Resolve: #5


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please proceed with merging, as this was approved.

@pirj pirj force-pushed the add_option_for_consistent_parentheses_style branch from 3915cab to 72c1a7f Compare May 14, 2023 20:01
@pirj pirj merged commit 3a1ae71 into master May 14, 2023
20 checks passed
@pirj pirj deleted the add_option_for_consistent_parentheses_style branch May 14, 2023 20:02
@pirj
Copy link
Member

pirj commented May 14, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FactoryBot/FactoryNameStyle false positive on rails generators
2 participants