Add ExplicitOnly configuration option to RSpec/FactoryBot/ConsistentParenthesesStyle, RSpec/FactoryBot/CreateList and RSpec/FactoryBot/FactoryNameStyle

[ydah]

Follow up: #1482 (comment)
Resolve: rubocop/rubocop-factory_bot#5

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

• Set VersionChanged in config/default.yml to the next major version.

[Darhazer]

I was thinking whether this could be applied to RSpec/FactoryBot (the whole department) and affect the matcher on the receiver (whether to include nil receiver or not). @pirj WDYT?

[ydah]

Indeed it is, looks good. So we cut out ExplicitOnly into a common class to make it easier to handle, and added the configuration values to the other cop. WDYT?

[pirj]

We have FactoryBot/SyntaxMethods already that enforces FactoryBot.create vs just create, right?
Is there a situation where non-explicit and explicit would be used sparingly?
I'm hinting that those two cops together can enforce any given style combination, and this makes the option redundant.
Can you please help me understand the need for this option?

[Darhazer]

Suppose you want to use FactoryBot only with explicit receiver - as you are using methods like create either from another gem or defined yourself. So you disable the SyntaxMethods cop. The idea is to prevent the other FactoryBot cops of raising false positives.

[ydah]

My understanding is that FactoryBot/SyntaxMethods can explicitly force FactoryBot to be a receiver or not.
Therefore, methods such as create that do not explicitly have a receiver with FactoryBot can be considered as not belonging to FactoryBot, so setting this option to true will help exclude methods with the same name other than FactoryBot, which would be a false positive. We believe that this option will help to exclude methods with the same name other than FactoryBot that are false positive.

[ydah]

It was conflicted, so I rebased it to the latest master branch.

[ydah]

I rebased and resolved the conflict.

[pirj]

I'd hold this off until rubocop-factroy_bot extraction.

[ydah]

I've opened a PR in the rubocop-factory_bot repository and this one is closed

• Add ExplicitOnly configuration option to FactoryBot/ConsistentParenthesesStyle, FactoryBot/CreateList and FactoryBot/FactoryNameStyle rubocop-factory_bot#18