Update AssertOperator and RefuteOperator to allow :[]

rubocop · Sep 26, 2023 · 1a7ca4d · 1a7ca4d
1 parent 05da8ea
commit 1a7ca4d
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/lib/rubocop/cop/minitest/assert_operator.rb b/lib/rubocop/cop/minitest/assert_operator.rb
@@ -18,11 +18,15 @@ class AssertOperator < Base
 
         MSG = 'Prefer using `assert_operator(%<new_arguments>s)`.'
         RESTRICT_ON_SEND = %i[assert].freeze
+        ALLOWED_OPERATORS = [:[]].freeze
 
         def on_send(node)
           first_argument = node.first_argument
           return unless first_argument.respond_to?(:operator_method?) && first_argument.operator_method?
 
+          operator = first_argument.to_a[1]
+          return if ALLOWED_OPERATORS.include?(operator)
+
           new_arguments = build_new_arguments(node)
 
           add_offense(node, message: format(MSG, new_arguments: new_arguments)) do |corrector|

diff --git a/lib/rubocop/cop/minitest/refute_operator.rb b/lib/rubocop/cop/minitest/refute_operator.rb
@@ -18,11 +18,15 @@ class RefuteOperator < Base
 
         MSG = 'Prefer using `refute_operator(%<new_arguments>s)`.'
         RESTRICT_ON_SEND = %i[refute].freeze
+        ALLOWED_OPERATORS = [:[]].freeze
 
         def on_send(node)
           first_argument = node.first_argument
           return unless first_argument.respond_to?(:operator_method?) && first_argument.operator_method?
 
+          operator = first_argument.to_a[1]
+          return if ALLOWED_OPERATORS.include?(operator)
+
           new_arguments = build_new_arguments(node)
 
           add_offense(node, message: format(MSG, new_arguments: new_arguments)) do |corrector|

diff --git a/test/rubocop/cop/minitest/assert_operator_test.rb b/test/rubocop/cop/minitest/assert_operator_test.rb
@@ -81,4 +81,14 @@ def test_do_something
       end
     RUBY
   end
+
+  def test_does_not_consider_brackets_to_be_an_offense
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        def test_do_something
+          assert(array_of_booleans[42])
+        end
+      end
+    RUBY
+  end
 end
diff --git a/test/rubocop/cop/minitest/refute_operator_test.rb b/test/rubocop/cop/minitest/refute_operator_test.rb
@@ -81,4 +81,14 @@ def test_do_something
       end
     RUBY
   end
+
+  def test_does_not_consider_brackets_to_be_an_offense
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        def test_do_something
+          refute(array_of_booleans[42])
+        end
+      end
+    RUBY
+  end
 end