Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minitest/GlobalExpectations support other minitest expectations #66

Closed
yahonda opened this issue Mar 10, 2020 · 0 comments · Fixed by #67
Closed

Minitest/GlobalExpectations support other minitest expectations #66

yahonda opened this issue Mar 10, 2020 · 0 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@yahonda
Copy link
Contributor

yahonda commented Mar 10, 2020

Is your feature request related to a problem? Please describe.

#63 implements Minitest/GlobalExpectations cop and I've found other minitest expectations need to be supported by Minitest/GlobalExpectations cop.

Describe the solution you'd like

google-cloud-storage unit test needs these expectations:

must_be
must_be_kind_of
must_be_nil
must_be_within_delta
must_equal
must_include
must_match
wont_be
wont_be_nil

Looks like all minitest expectations are written in https://github.com/seattlerb/minitest/blob/master/lib/minitest/expectations.rb

Describe alternatives you've considered

Edit test cases by hand.

Additional context

No additional information.
@koic koic added the enhancement New feature or request label Mar 12, 2020
koic added a commit to koic/rubocop-minitest that referenced this issue Mar 13, 2020
@koic
[Fix rubocop#66] Support all expectations of Minitest::Expectations
6708594 
Resolves rubocop#66.

This PR supports all expectations of `Minitest::Expectations` for
`Minitest/GlobalExpectations` cop.
https://github.com/seattlerb/minitest/blob/v5.14.0/lib/minitest/expectations.rb
@koic koic mentioned this issue Mar 13, 2020
Merged
8 tasks
@koic koic closed this as completed in #67 Mar 15, 2020
koic added a commit that referenced this issue Mar 15, 2020
@koic
Merge pull request #67 from koic/support_all_expectations_for_global_…
234cd53 
…expectations

[Fix #66] Support all expectations of `Minitest::Expectations`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #66] Support all expectations of Minitest::Expectations koic/rubocop-minitest
2 participants
@koic @yahonda