Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #66] Support all expectations of Minitest::Expectations #67

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 13, 2020

Resolves #66.

This PR supports all expectations of Minitest::Expectations for Minitest/GlobalExpectations cop.
https://github.com/seattlerb/minitest/blob/v5.14.0/lib/minitest/expectations.rb


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Resolves rubocop#66.

This PR supports all expectations of `Minitest::Expectations` for
`Minitest/GlobalExpectations` cop.
https://github.com/seattlerb/minitest/blob/v5.14.0/lib/minitest/expectations.rb
@koic koic merged commit 234cd53 into rubocop:master Mar 15, 2020
@koic koic deleted the support_all_expectations_for_global_expectations branch March 15, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest/GlobalExpectations support other minitest expectations
1 participant