[Fix #52] Fix a false negative for Minitest/RefuteIncludes
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#52. This PR fixes a false negative for `Minitest/AssertIncludes` and `Minitest/RefuteIncludes` when an argument is enclosed in redundant parentheses. Probably will be corrected separately for similar false negatives that other cops will have.
koic
changed the title
Minitest/RefuteIncludesMinitest/RefuteIncludes
koic
force-pushed
the
fix_false_negative_for_refute_includes
branch
from
ff99ea1
to
d9ad1b1
Compare
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 2, 2020
…atch` Follow rubocop#54. This PR fixes a false negative for `Minitest/AssertMatch` and `Minitest/RefuteMatch` when an argument is enclosed in redundant parentheses.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 3, 2020
Follow rubocop#54. This PR fixes a false negative for `Minitest/AssertRespondTo` and `Minitest/RefuteRespondTo` when an argument is enclosed in redundant parentheses.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 4, 2020
Follow rubocop#54. Fix a false negative for `Minitest/AssertInstanceOf` and `Minitest/RefuteInstanceOf` when an argument is enclosed in redundant parentheses.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 4, 2020
Follow rubocop#54. This PR fixes a false negative for `Minitest/AssertEmpty` and `Minitest/RefuteEmpty` when an argument is enclosed in redundant parentheses.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Mar 19, 2020
Follow rubocop#54. This PR fixes a false negative for `Minitest/AssertEqual` when an argument is enclosed in redundant parentheses.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52.
This PR fixes a false negative for
Minitest/AssertIncludesandMinitest/RefuteIncludeswhen an argument is enclosed in redundant parentheses.Probably will be corrected separately for similar false negatives that other cops will have.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.