Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Performance/RedundantStringChars #273

Conversation

koic
Copy link
Member

@koic koic commented Nov 18, 2021

Follow up to #249 (comment).

This PR fixes an incorrect autocorrect for Performance/RedundantStringChars when using str.chars[0].


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up to rubocop#249 (comment).

This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars`
when using `str.chars[0]`.
@koic koic force-pushed the fix_incorrect_autocorrect_for_performance_redundant_string_chars branch from 97b7698 to 548a211 Compare November 18, 2021 03:15
@koic koic merged commit aa2a2e3 into rubocop:master Nov 18, 2021
@koic koic deleted the fix_incorrect_autocorrect_for_performance_redundant_string_chars branch November 18, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant