Update the doc for Performance/Count
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 22, 2023
| @@ -544,8 +544,7 @@ passed to the `count` call. | |||
| === Safety | |||
|
|
|||
| This cop is unsafe because it has known compatibility issues with `ActiveRecord` and other | |||
| frameworks. ActiveRecord's `count` ignores the block that is passed to it. | |||
| `ActiveRecord` will ignore the block that is passed to `count`. | |||
| frameworks. Before Rails 5.1, `ActiveRecord` will ignore the block that is passed to `count`. | |||
There was a problem hiding this comment.
This adoc file is auto-generated, so no changes are necessary.
|
Can you squash your commits into one? |
- Remove duplicate sentences - Specify Rails version about ActiveRecord behavior description The described behavior of `count` method has been fixed at Rails 5.1. <https://guides.rubyonrails.org/5_1_release_notes.html> > Fixed ActiveRecord::Relation#count to use Ruby's Enumerable#count for counting records when a block is passed as argument instead of silently ignoring the passed block.
ryym
force-pushed
the
update_doc_for_performance_count
branch
from
ba1885e
to
9c6704e
Compare
|
Thank you for your reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the doc for
Performance/Count.Removed almost duplicate sentences (left the latter one only):
Added Rails version that fixed the described
countmethod issue. Since it has been fixed in 2016, newer Rails users will not encounter this issue.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.