Add some documents #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some documents with reference to RuboCop Performance. rubocop/rubocop-performance#29
|
Nice! I guess we should also add some note that the |
|
I mostly want us to address confusion like #56 |
Closed
Yup! It will be a very good note! And please wait for this PR merge. I'd like to merge before the initial release of RuboCop Rails 2.0. |
I'd like to release first and maintain those documents later. |
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
May 24, 2019
This PR adds a reference to `rubocop-rails_config` gem in README.md Fixes rubocop#56. Follow up rubocop#57 (comment). Follow up rubocop/rubocop#5976 (comment).
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
May 24, 2019
…DME.md This PR adds a reference to `rubocop-rails_config` gem in README.md Fixes rubocop#56. Follow up rubocop#57 (comment). Follow up rubocop/rubocop#5976 (comment).
8 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
May 24, 2019
…DME.md This PR adds a reference to `rubocop-rails_config` gem in README.md Fixes rubocop#56. Follow up rubocop#57 (comment). Follow up rubocop/rubocop#5976 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documents with reference to RuboCop Performance.
rubocop/rubocop-performance#29
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.