Fix test case in file_path_spec.rb for Style/RedundantStringEscape
#798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
koic
reviewed
Sep 29, 2022
Comment on lines
118
to
119
| expect_no_offenses(<<~RUBY) | ||
| puts "test #\{123\}. Hey!" | ||
| puts "test #{described_class}. Hey!" |
There was a problem hiding this comment.
This is fine, but can you tweak it as follows?
- expect_no_offenses(<<~RUBY)
- puts "test #\{123\}. Hey!"
+ expect_no_offenses(<<~'RUBY')
+ puts "test #{123}. Hey!"
RUBYThere was a problem hiding this comment.
That's what I did at first, but it fails with Lint/LiteralInInterpolation.
So it seems that the inside of #{} must be some variable.
There was a problem hiding this comment.
Changing the heredoc identifier from <<~RUBY to <<~'RUBY' would solve the issue.
koic
reviewed
Sep 29, 2022
| @@ -245,7 +245,7 @@ | |||
| context 'when string contains an interpolation followed by a period' do | |||
| it 'does not register an offense' do | |||
| expect_no_offenses(<<~RUBY) | |||
| puts "test #\{123\}. Hey!" | |||
| puts "test #{described_class}. Hey!" | |||
kkitadate
force-pushed
the
fix-test-case-in-file_path_spec-for-redundant-string-escape
branch
from
db8c22d
to
c3d9ecf
Compare
koic
reviewed
Sep 29, 2022
| @@ -115,7 +115,7 @@ | |||
|
|
|||
| context 'when string contains an interpolation followed by a period' do | |||
| it 'does not register an offense' do | |||
| expect_no_offenses(<<~RUBY) | |||
| expect_no_offenses(<<~'RUBY') | |||
| puts "test #\{123\}. Hey!" | |||
There was a problem hiding this comment.
<<~'RUBY' can remove the \.
Suggested change
| puts "test #\{123\}. Hey!" | |
| puts "test #{123}. Hey!" |
There was a problem hiding this comment.
Thanks, I fixed it.
CI seems to have failed because rubocop/rubocop#11002 was merged (e.g. rubocop@2723be4) This commit is for fixing it.
kkitadate
force-pushed
the
fix-test-case-in-file_path_spec-for-redundant-string-escape
branch
from
c3d9ecf
to
7b07474
Compare
|
👍 |
kkitadate
deleted the
fix-test-case-in-file_path_spec-for-redundant-string-escape
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI seems to have failed because rubocop/rubocop#11002 was merged. (e.g. 2723be4)
This commit is for fixing it.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.