[Fixes #10439] Add Style/RedundantStringEscape #11002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Sep 28, 2022
| module RuboCop | ||
| module Cop | ||
| module Style | ||
| # Checks for redundant escapes in Strings. |
bbatsov
reviewed
Sep 28, 2022
| include RangeHelp | ||
| extend AutoCorrector | ||
|
|
||
| MSG = 'Redundant escape inside string literal.' |
There was a problem hiding this comment.
Perhaps we should mention the exact escape in the message?
bbatsov
reviewed
Sep 28, 2022
| module Style | ||
| # Checks for redundant escapes in Strings. | ||
| # | ||
| # @example |
There was a problem hiding this comment.
Probably you should add a couple of examples with heredocs as well, so it's clear to everyone those are considered.
bbatsov
approved these changes
Sep 29, 2022
|
Well done! |
9 tasks
kkitadate
added a commit
to kkitadate/rubocop-rails
that referenced
this pull request
Sep 29, 2022
CI seems to have failed because rubocop/rubocop#11002 was merged (e.g. rubocop@2723be4) This commit is for fixing it.
6 tasks
kkitadate
added a commit
to kkitadate/rubocop-rails
that referenced
this pull request
Sep 29, 2022
CI seems to have failed because rubocop/rubocop#11002 was merged (e.g. rubocop@2723be4) This commit is for fixing it.
kkitadate
added a commit
to kkitadate/rubocop-rails
that referenced
this pull request
Sep 29, 2022
CI seems to have failed because rubocop/rubocop#11002 was merged (e.g. rubocop@2723be4) This commit is for fixing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
Style/RedundantStringEscapecop, as suggested in #10439Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.