Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 2.3 #33

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Drop support for Ruby 2.3 #33

merged 2 commits into from
Nov 3, 2020

Commits on Nov 3, 2020

  1. Drop support for Ruby 2.3. 

    This commit drops support for Ruby 2.3 and suppresses the following
`Gemspec/RequiredRubyVersion` offense.

```console
% cd path/to/rubocop-rake
% bundle exec rake
(snip)

Offenses:

rubocop-rake.gemspec:14:32: C: Gemspec/RequiredRubyVersion:
required_ruby_version (2.3, declared in rubocop-rake.gemspec) and
TargetRubyVersion (2.4, which may be specified in .rubocop.yml) should
be equal.
  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

25 files inspected, 1 offense detected
```
    @koic
    koic committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f2f1dd1 View commit details
    Browse the repository at this point in the history

  2. Fix build error 

    This commit fixes the following `RSpec/FactoryBot/CreateList` error.

```console
% cd path/to/rubocop-rake
% bundle exec rake
(snip)

An error occurred while RSpec/FactoryBot/CreateList cop was inspecting
/Users/koic/src/github.com/rubocop-hq/rubocop-rake/spec/spec_helper.rb:15:15.
To see the complete backtrace run rubocop -d.
```
    @koic
    koic committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    d884630 View commit details
    Browse the repository at this point in the history