Merge pull request #1443 from ydah/fix/1442

Fix an incorrect autocorrect for `FactoryBot/ConsistentParenthesesStyle` with `omit_parentheses` option when method name and first argument are not on same line

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Master (Unreleased)
 
+- Fix an incorrect autocorrect for `FactoryBot/ConsistentParenthesesStyle` with `omit_parentheses` option when method name and first argument are not on same line. ([@ydah])
 - Fix autocorrection loop in `RSpec/ExampleWording` for insufficient example wording. ([@pirj])
 - Fix `RSpec/SortMetadata` not to reorder arguments of `include_`/`it_behaves_like`. ([@pirj])
 - Fix a false positive for `RSpec/NoExpectationExample` when allowed pattern methods with arguments. ([@ydah])

docs/modules/ROOT/pages/cops_rspec_factorybot.adoc

@@ -96,6 +96,16 @@ create :user
 build :user
 create :login
 create :login
+
+# also good
+# when method name and first argument are not on same line
+create(
+  :user
+)
+build(
+  :user,
+  name: 'foo'
+)
 ----
 
 === Configurable attributes

lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb

@@ -30,6 +30,16 @@ module FactoryBot
         #   create :login
         #   create :login
         #
+        #   # also good
+        #   # when method name and first argument are not on same line
+        #   create(
+        #     :user
+        #   )
+        #   build(
+        #     :user,
+        #     name: 'foo'
+        #   )
+        #
         class ConsistentParenthesesStyle < Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
@@ -66,6 +76,7 @@ def on_send(node)
 
           def process_with_parentheses(node)
             return unless style == :omit_parentheses
+            return unless same_line?(node, node.first_argument)
 
             add_offense(node.loc.selector,
                         message: MSG_OMIT_PARENS) do |corrector|

spec/rubocop/cop/rspec/factory_bot/consistent_parentheses_style_spec.rb

@@ -275,5 +275,43 @@
         end
       RUBY
     end
+
+    context 'when create and first argument are on same line' do
+      it 'register an offense' do
+        expect_offense(<<~RUBY)
+          create(:user,
+          ^^^^^^ Prefer method call without parentheses
+            name: 'foo'
+          )
+        RUBY
+
+        expect_correction(<<~RUBY)
+          create :user,
+            name: 'foo'
+
+        RUBY
+      end
+    end
+
+    context 'when create and first argument are not on same line' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY)
+          create(
+            :user
+          )
+        RUBY
+      end
+    end
+
+    context 'when create and some argument are not on same line' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY)
+          create(
+            :user,
+            name: 'foo'
+          )
+        RUBY
+      end
+    end
   end
 end