Fix an incorrect autocorrect for FactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method name and first argument are not on same line
#1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
changed the title
FactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method and first argument are not on same lineFactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method name and first argument are not on same line
ydah
force-pushed
the
fix/1442
branch
2 times, most recently
from
45d08e4
to
7c8e11a
Compare
pirj
reviewed
Oct 25, 2022
spec/rubocop/cop/rspec/factory_bot/consistent_parentheses_style_spec.rb
Outdated
Show resolved
Hide resolved
…le` with `omit_parentheses` option when method name and first argument are not on same line Fix: rubocop#1442 This PR is following cases where the method name and the first argument are different line are not considered offense. ```ruby create( :user ) build( :user, name: 'foo' ) ``` This is because the absence of parentheses will result in a syntax error. ```ruby create :user build :user, name: 'foo' ``` In that case, the following modification would be necessary, and we have chosen not to make it an offense here, since we would have to suppress either offense if there is a length limit in Layout/LineLength, etc. ```ruby create :user build :user, name: 'foo' ```
|
In general, I agree that this is the way to quick-fix the problem with autocorrection. |
|
I think this is fine for a bugfix. We can consider the |
|
@bquorning I take your last comment as an approval. @ydah Thank you! |
bquorning
pushed a commit
that referenced
this pull request
Oct 25, 2022
Fix an incorrect autocorrect for `FactoryBot/ConsistentParenthesesStyle` with `omit_parentheses` option when method name and first argument are not on same line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1442
This PR is following cases where the method name and the first argument are different line are not considered offense.
This is because the absence of parentheses will result in a syntax error.
In that case, the following modification would be necessary, and we have chosen not to make it an offense here, since we would have to suppress either offense if there is a length limit in Layout/LineLength, etc.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).