New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire RSpec/InvalidPredicateMatcher
#938
Comments
I stand by my comment in #441 (comment):
As for the “editor integration” argument, that opens the door to catch a lot of “typo” class offenses that I really think we shouldn’t bother with. |
I guess in the early days when there were not so many cops, all kinds of checks were accepted. Now we can choose wisely. On the other hand, do we need to retire it? I would suggest we do so in major versions, like when we bump the requirement of rubocop to 1.0, and probably - do a review of all cops and decide if some are to be retired, so have all the deprecations in one release ;) Last, but not least, Rubocop itself has a |
I agree, looking into how Rubocop extensions can use Which makes me think – do we need a forum for discussing RuboCop extensions together with maintainers of the other official extensions? |
While not fixed in Closing. |
As far as I remember, according to our non-goals (a rather incomplete version of what we have in mind) it's not our business to notify the user about things that RSpec will notify with a spec failure, warning, or an error.
I clearly understand that with the editor integration it may highlight this problem earlier.
On the other hand, we don't provide auto-correction anyway.
It's an interesting topic of what we should keep, and what to retire, as this cop might be helpful for some people in some circumstances, but in general, it's not the goal of RuboCop RSpec.
WDYT @bquorning @Darhazer ?
The text was updated successfully, but these errors were encountered: